Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Nov 6, 2025

Description

Introduces a CDDL schema processing for Content validation rule.

Description of Changes

  • Removed catalyst_signed_doc::validator::json_schema:: JsonSchema and replaced with the newly added catalyst_types::json_schema::JsonSchema.
  • Update catalyst-signed-doc-spec, process CDDl definitions as well.
  • Modified Content validation rule, added CDDL schema processing (without applying validation against CDDL schema).

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Nov 6, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Nov 6, 2025
stevenj
stevenj previously approved these changes Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/cddl-schema

@stevenj stevenj enabled auto-merge (squash) November 6, 2025 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Test Report | ${\color{lightgreen}Pass: 554/554}$ | ${\color{red}Fail: 0/554}$ |

@stevenj stevenj self-requested a review November 6, 2025 14:41
@stevenj stevenj merged commit b703f01 into main Nov 6, 2025
23 checks passed
@stevenj stevenj deleted the feat/cddl-schema branch November 6, 2025 14:42
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants