Skip to content

feat(rust/rbac-registration): RBAC refactoring feature branch #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 25, 2025
Merged

feat(rust/rbac-registration): RBAC refactoring feature branch #630

merged 19 commits into from
Nov 25, 2025

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Nov 7, 2025 •
edited
Loading

Description

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem @Mr-Leshiy
feat(rust/rbac-registration): Add provider trait for `RegistrationCha…
ac4093c 
…in` (#586)

* initial

* feat: provider

* feat: update chain

* feat: start_new_chain

* feat: merge validation result struct into cip509

* feat: exports

* feat: return new chain

* chore: return success object

* fix: older version

* feat: cat id in payload

* fix: new version

* chore: lintfix

* chore: remove persistent arguments

* tmp

* chore: complete moving to central module

* feat: ref fn

* chore: merge methods

* chore: minor

* feat: export modified chains

* chore: minor comment

* chore: rbac update logic

* chore: isolation

* chore: validation and lintfix

* docs: remove error doc

* chore: minor refactor

* fix: comments

* chore: validation function return

* Update rust/rbac-registration/src/providers.rs

Co-authored-by: Alex Pozhylenkov <leshiy12345678@gmail.com>

---------

Co-authored-by: Alex Pozhylenkov <leshiy12345678@gmail.com>
@Mr-Leshiy Mr-Leshiy added the draft Draft label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/rbac

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 566/566}$ | ${\color{red}Fail: 0/566}$ |

@Mr-Leshiy
feat(rust/rbac-registration): RBAC stolen StakeAddress handling. (#631
5c0b665 
)

* wip

* wip

* wip

* wip

* revert

* wip

* add stolen_uris field

* wip

* wip

* wip

* fix

* wip

* wip

* fix spelling

* fix

* wip

* wip

* wip

* wip

* cleanup

* fix test

* fix clippy

* wip

* wip

* fix

* wip

* fix clippy

* fix

* wip

* wip
@Mr-Leshiy
Merge branch 'main' into feat/rbac
7781517
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team do not merge yet PR is not ready to be merged yet and removed draft Draft labels Nov 19, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Nov 19, 2025
rafal-ch
rafal-ch reviewed Nov 20, 2025
View reviewed changes
Mr-Leshiy and others added 2 commits November 20, 2025 18:00
@Mr-Leshiy @rafal-ch
Update rust/rbac-registration/src/registration/cardano/mod.rs
f930f44 
Co-authored-by: Rafał Chabowski <rafal.chabowski@iohk.io>
@Mr-Leshiy
fix suggestions
99aebda
rafal-ch
rafal-ch previously approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bkioshn
bkioshn reviewed Nov 21, 2025
View reviewed changes
bkioshn
bkioshn reviewed Nov 24, 2025
View reviewed changes
bkioshn
bkioshn reviewed Nov 24, 2025
View reviewed changes
@Mr-Leshiy Mr-Leshiy added the fyi: hermetics For information - Hermes Backend, System Development & Integration Team label Nov 25, 2025
bkioshn
bkioshn reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, just a small improvement to a doc

Mr-Leshiy and others added 3 commits November 25, 2025 16:39
@Mr-Leshiy @bkioshn
Update rust/rbac-registration/src/cardano/cip509/cip509.rs
ff26c8a 
Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com>
@Mr-Leshiy
fix fmt
9bcec57
@Mr-Leshiy
fix fmt
74f8cd0
rafal-ch
rafal-ch approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mr-Leshiy Mr-Leshiy merged commit ba6ad3e into main Nov 25, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/rbac branch November 25, 2025 15:36
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafal-ch rafal-ch rafal-ch approved these changes

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach

@apskhem apskhem Awaiting requested review from apskhem

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@Mr-Leshiy Mr-Leshiy

Labels

do not merge yet PR is not ready to be merged yet fyi: hermetics For information - Hermes Backend, System Development & Integration Team review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Catalyst
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mr-Leshiy @bkioshn @rafal-ch @apskhem