-
Notifications
You must be signed in to change notification settings - Fork 1
feat(rust/signed-doc): DocLocator validation during fetching from the CatalystSignedDocumentProvider
#659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stanislav-tkach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but Clippy isn't happy with the check function size. I propose to make the validator lambda a separate function instead of adding the allow attribute.
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/libs/feat/full-doc-ref-check |
|
✅ Test Report | |
apskhem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implemented a proper
DocumentRefvalidation with the referenced document which was fetched from the provider.The
DocumentRefvalue from the metadata field must exactly match with the actualDocumentRefcalculated from the fetched document.This way we are ensuring that the provider would return a correct document, according to the asked
DocumentRef.Refactored
ChainRule::checkmethod, usedoc_refs_checkto apply full set ofDocumentRefchecks.Related Issue(s)
Closes #644
Description of Changes
Please confirm the following checks