-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-gateway): Updated Catalyst Signed Document validation #3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Oct 6, 2025
Comment on lines
+17
to
+20
| /// List of category documents, categories. | ||
| #[rustfmt::skip] | ||
| pub(crate) const CATEGORY_DOCUMENTS: [CategoryDocData; 12] = [ | ||
| CategoryDocData("0194d490-30bf-7473-81c8-a0eaef369619"), | ||
| CategoryDocData("0194d490-30bf-7043-8c5c-f0e09f8a6d8c"), | ||
| CategoryDocData("0194d490-30bf-7e75-95c1-a6cf0e8086d9"), | ||
| CategoryDocData("0194d490-30bf-7703-a1c0-83a916b001e7"), | ||
| CategoryDocData("0194d490-30bf-79d1-9a0f-84943123ef38"), | ||
| CategoryDocData("0194d490-30bf-706d-91c6-0d4707f74cdf"), | ||
| CategoryDocData("0194d490-30bf-759e-b729-304306fbaa5e"), | ||
| CategoryDocData("0194d490-30bf-7e27-b5fd-de3133b54bf6"), | ||
| CategoryDocData("0194d490-30bf-7f9e-8a5d-91fb67c078f2"), | ||
| CategoryDocData("0194d490-30bf-7676-9658-36c0b67e656e"), | ||
| CategoryDocData("0194d490-30bf-7978-b031-7aa2ccc5e3fd"), | ||
| CategoryDocData("0194d490-30bf-7d34-bba9-8498094bd627"), | ||
| CategoryDocData("0194d490-30bf-7473-81c8-a0eaef369619", CAMPAIGN_ID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious and checked that: as far as I can see, the rustfmt::skip does nothing here. Perhaps it was useful before we made some of the formatting changes, but unless I'm missing something it can be removed now.
nathanbogale
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
requires architecture review
Requires at least 1 architect to sign off on PR before merge.
review me
PR is ready for review
squad: gatekeepers
Catalyst App Backend, System Development & Integration Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying Catalyst Signed Documents validation rules, by applying updated crate version input-output-hk/catalyst-libs#574.
New rules enforces to always have a
parameters(category_id) metadata field for all document types (Proposal, Comment, Proposal Submission Action), and it's no longer optional.Any Proposal, Comment or Proposal Submission Action which would be referencing any fund 14 template would be rejected.
Added fund 15 hardcoded document ids, with the fund 14 content (will be updated later).
Please confirm the following checks