Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 25, 2025

Description

Modifying Catalyst Signed Documents validation rules, by applying updated crate version input-output-hk/catalyst-libs#574.
New rules enforces to always have a parameters (category_id) metadata field for all document types (Proposal, Comment, Proposal Submission Action), and it's no longer optional.
Any Proposal, Comment or Proposal Submission Action which would be referencing any fund 14 template would be rejected.

Added fund 15 hardcoded document ids, with the fund 14 content (will be updated later).

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Sep 26, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team requires architecture review Requires at least 1 architect to sign off on PR before merge. labels Oct 6, 2025
Comment on lines +17 to +20
/// List of category documents, categories.
#[rustfmt::skip]
pub(crate) const CATEGORY_DOCUMENTS: [CategoryDocData; 12] = [
CategoryDocData("0194d490-30bf-7473-81c8-a0eaef369619"),
CategoryDocData("0194d490-30bf-7043-8c5c-f0e09f8a6d8c"),
CategoryDocData("0194d490-30bf-7e75-95c1-a6cf0e8086d9"),
CategoryDocData("0194d490-30bf-7703-a1c0-83a916b001e7"),
CategoryDocData("0194d490-30bf-79d1-9a0f-84943123ef38"),
CategoryDocData("0194d490-30bf-706d-91c6-0d4707f74cdf"),
CategoryDocData("0194d490-30bf-759e-b729-304306fbaa5e"),
CategoryDocData("0194d490-30bf-7e27-b5fd-de3133b54bf6"),
CategoryDocData("0194d490-30bf-7f9e-8a5d-91fb67c078f2"),
CategoryDocData("0194d490-30bf-7676-9658-36c0b67e656e"),
CategoryDocData("0194d490-30bf-7978-b031-7aa2ccc5e3fd"),
CategoryDocData("0194d490-30bf-7d34-bba9-8498094bd627"),
CategoryDocData("0194d490-30bf-7473-81c8-a0eaef369619", CAMPAIGN_ID),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious and checked that: as far as I can see, the rustfmt::skip does nothing here. Perhaps it was useful before we made some of the formatting changes, but unless I'm missing something it can be removed now.

@Mr-Leshiy Mr-Leshiy merged commit b2e3b43 into f15/cat-gateway Oct 7, 2025
24 of 26 checks passed
@Mr-Leshiy Mr-Leshiy deleted the f15/signed-doc-validation branch October 7, 2025 03:35
@github-project-automation github-project-automation bot moved this from New to ✅ Done in Catalyst Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires architecture review Requires at least 1 architect to sign off on PR before merge. review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants