Skip to content

Conversation

@aido-mth
Copy link
Contributor

@aido-mth aido-mth commented Nov 20, 2025

Description

Implemented channel opening for doc-sync RTE

Related Issue(s)

Closes #627

Description of Changes

  • Add pubsub subscription to doc-sync runtime extension
  • Add DOC_SYNC_STATE that keeps track of all active channel subscriptions across all apps
  • Update api.wit so close does not accept channel name
  • Add test that checks if connection is opened

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@aido-mth aido-mth force-pushed the aido/627/hermes-doc-sync branch 2 times, most recently from 8fc9273 to 991bcf9 Compare November 24, 2025 06:50
@aido-mth aido-mth added the squad: hermetics Hermes Backend, System Development & Integration Team label Nov 24, 2025
@rafal-ch rafal-ch moved this from New to 🏗 In progress in Catalyst Nov 24, 2025
@aido-mth aido-mth force-pushed the aido/627/hermes-doc-sync branch from 6a8dd14 to d10f00d Compare November 25, 2025 08:40
@aido-mth aido-mth marked this pull request as ready for review November 25, 2025 08:52
@aido-mth aido-mth added review me PR is ready for review rr: hermetics Required review by hermes team labels Nov 25, 2025
@aido-mth aido-mth moved this from 🏗 In progress to 👀 In review in Catalyst Nov 25, 2025
@github-actions
Copy link

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/hermes/aido/627/hermes-doc-sync

@aido-mth aido-mth force-pushed the aido/627/hermes-doc-sync branch from 6584369 to 9be7385 Compare November 26, 2025 11:58
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Nov 26, 2025
no30bit
no30bit previously approved these changes Nov 27, 2025
rafal-ch
rafal-ch previously approved these changes Nov 27, 2025
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aido-mth aido-mth mentioned this pull request Nov 27, 2025
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aido-mth aido-mth merged commit dee73bc into main Nov 27, 2025
56 checks passed
@aido-mth aido-mth deleted the aido/627/hermes-doc-sync branch November 27, 2025 10:49
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Catalyst Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review rr: hermetics Required review by hermes team squad: hermetics Hermes Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK]: Allow Hermes app to open (join) IPFS channel

4 participants