-
Notifications
You must be signed in to change notification settings - Fork 3
feat(hermes): add ipfs connection opening to doc_sync #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fc9273 to
991bcf9
Compare
6a8dd14 to
d10f00d
Compare
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/hermes/aido/627/hermes-doc-sync |
rafal-ch
reviewed
Nov 26, 2025
6584369 to
9be7385
Compare
no30bit
requested changes
Nov 26, 2025
hermes/bin/tests/integration/components/ipfs_subscribe/src/lib.rs
Outdated
Show resolved
Hide resolved
hermes/bin/tests/integration/components/ipfs_subscribe/src/lib.rs
Outdated
Show resolved
Hide resolved
no30bit
previously approved these changes
Nov 27, 2025
rafal-ch
previously approved these changes
Nov 27, 2025
Contributor
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
rafal-ch
approved these changes
Nov 27, 2025
Contributor
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review me
PR is ready for review
rr: hermetics
Required review by hermes team
squad: hermetics
Hermes Backend, System Development & Integration Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented channel opening for doc-sync RTE
Related Issue(s)
Closes #627
Description of Changes
DOC_SYNC_STATEthat keeps track of all active channel subscriptions across all appsapi.witso close does not accept channel namePlease confirm the following checks