Skip to content

Conversation

@aido-mth
Copy link
Contributor

@aido-mth aido-mth commented Nov 25, 2025

Description

Add CI job that verifies if crate name is consistent with earthly build job

Related Issue(s)

Closes #667

Description of Changes

  • Add python script that goes throughout Earthfiles and Cargo.toml files and checks name consistency
  • Add check-earthly-names that runs script above

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@aido-mth aido-mth self-assigned this Nov 25, 2025
@aido-mth aido-mth requested a review from stevenj as a code owner November 25, 2025 13:13
@aido-mth aido-mth added the review me PR is ready for review label Nov 25, 2025
@aido-mth aido-mth added the squad: hermetics Hermes Backend, System Development & Integration Team label Nov 25, 2025
@aido-mth aido-mth requested a review from bkioshn as a code owner November 25, 2025 13:13
@aido-mth aido-mth added the rr: hermetics Required review by hermes team label Nov 25, 2025
@aido-mth aido-mth moved this from New to 👀 In review in Catalyst Nov 25, 2025
@aido-mth aido-mth changed the title feat(CI): crate name consistency check with earthly feat(hermes): crate name consistency check with earthly Nov 25, 2025
@github-actions
Copy link

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/hermes/aido/667/check-name-consistency

@rafal-ch
Copy link
Contributor

Nice one, thanks!

Could you please remove all # Keep it consistent with Earthly build output name. comments?

@aido-mth
Copy link
Contributor Author

Nice one, thanks!

Could you please remove all # Keep it consistent with Earthly build output name. comments?

Updated in e79a63b.

Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aido-mth aido-mth merged commit 5623d6b into main Nov 25, 2025
56 checks passed
@aido-mth aido-mth deleted the aido/667/check-name-consistency branch November 25, 2025 14:27
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review rr: hermetics Required review by hermes team squad: hermetics Hermes Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[TASK] : Add CI job that verifies if crate name is consistent with earthly build job

3 participants