Skip to content

Conversation

@greatertomi
Copy link
Contributor

@greatertomi greatertomi commented Nov 21, 2025

Checklist

  • JIRA - LW-13671
  • Proper tests implemented
  • Screenshots added.

Proposed solution

This reorganizes the repo so that it combines both v1 and v2 codebase

  • v1: Contains all of the previous lace code
  • v2: Is a submodule of lace-platform

Testing

  1. Run the setup that initializes submodules, installs dependencies, and creates .env

    make setup
    
  2. Run build at the project root. This will build both the v1 and v2 and also provide a bundle build in the root directory

    make build-prod
    

    or alternatively

    make build-dev
    

Screenshots

Attach screenshots here if implementation involves some UI changes

@greatertomi greatertomi requested review from a team as code owners November 21, 2025 11:59
@greatertomi greatertomi force-pushed the feat/lw-13671-integrate-lmp branch 9 times, most recently from 41313d1 to 3e2f15c Compare November 24, 2025 14:08
@lace-bot
Copy link
Collaborator

Allure Report

allure-report-publisher generated test report!

processReports: ➖ test report for 2db7f2db

passed failed skipped flaky total result
Total 0 0 0 0 0

@greatertomi greatertomi force-pushed the feat/lw-13671-integrate-lmp branch 7 times, most recently from 891608f to 761443e Compare November 27, 2025 08:33
@greatertomi greatertomi force-pushed the feat/lw-13671-integrate-lmp branch from 761443e to b0250d7 Compare November 27, 2025 09:35
- Add init-submodules target to pull git submodules
- Create .env with required Blockfrost variables
- Combine all steps into single `make setup` command
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/lw-13671-integrate-lmp branch from 0b33632 to 62d4329 Compare November 27, 2025 12:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
11 Security Hotspots
E Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants