refactor(minio): adopt x/minio pacakge

[pinglin]

Because

• all backends should share the x/minio package for accessing MinIO for blob operations.

This commit

• refactors the codebase to adopt the x/minio package.

[linear]

INS-7091 Refactor: Compact Blob Storage Logic for Worker and Service Layer

[jvallesm]

Besides removing deprecated methods (which unlocks further cleanup in the artifact service 👍), the new structure is significantly tidier ✨ Thanks for addressing this.

I added a couple of nonblocking comments regarding the fetcher injection.

[jvallesm]

nit: I wouldn't alias these unless there's a conflict with other package name (e.g. when we use the Temporal SDK and x/temporal, or when partially migrating a package like resource and we might need to use both the local and the x resource packages).

[pinglin]

The references of x packages across all backend repos can indeed often encounter naming conflict, especially for client, temporal, etc. I found it can improve readability by appending x as suffix to indicate the use of the x package no matter how.

[jvallesm]

nit: since Store is exported and used directly, not as an implementation of an interface, we can just make the s.BinaryFetcher field exported instead of implementing a getter method.

[jvallesm]

If you agree with this comment it wouldn't even be necessary to export it, as the downstream methods will initialise the fetcher themselves.

[pinglin]

That's a good point. I wasn't aware that component/store package has been instantiated in each reference.

[jvallesm]

❓ Do we need an interface here? It feels like unnecessary indirection. Here you removed the fetcher from the constructor params, but in other constructors where the arguments aren't wrapped in a struct you've kept them.

I think we can directly initialise binary.NewFetcher() wherever we're going to use it. We don't need to leverage the interface for testing and passing it nor having a single shared instance offers any benefit, and removing this would shorten the constructor signatures.

Suggested change

	}
	// Fetcher can be used to fetch binary data from a URL.
	type Fetcher struct {
	httpClient *resty.Client
	}
	// NewFetcher creates a new BinaryFetcher instance.
	func NewFetcher() *Fetcher {
	return &Fetcher{
	httpClient: resty.New().SetRetryCount(3),
	}
	}

[pinglin]

Yes, that makes sense.