Test dummy #2288
Closed
Test dummy #2288
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| function bootstrap() { | ||
| execSync(path.resolve('scripts/clean.js'), opts) |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 29 days ago
To eliminate the risk, refactor the code so that the child process executes the script directly via Node using its arguments array (and not via a shell command string). Replace the execSync invocation with fork, or with execFileSync('node', [cleanScriptPath], opts). This removes shell interpretation risk.
Steps:
- Change
execSync(path.resolve('scripts/clean.js'), opts)tofork(cleanScriptPath, [], opts), or useexecFileSync('node', [cleanScriptPath], opts). - Ensure that
cleanScriptPathusespath.resolveas before, to compute the absolute path toscripts/clean.js. - If you use
fork, note it runs the Node file as a child process (recommended for local scripts); if you useexecFileSync, you must invokenodeand pass the script path as an argument.
No new methods or imports are needed; fork is already imported from 'child_process' at the top of the file.
Suggested changeset
1
scripts/bootstrap.js
| @@ -65,7 +65,7 @@ | ||
| } | ||
|
|
||
| function bootstrap() { | ||
| execSync(path.resolve('scripts/clean.js'), opts) | ||
| fork(path.resolve('scripts/clean.js'), [], opts) | ||
| buildProject() | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.