Skip to content

🧪 add some tuple pbt tests #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

🧪 add some tuple pbt tests #150

merged 1 commit into from
Oct 9, 2024

Conversation

@lukevalenty
Copy link
Contributor

@lukevalenty lukevalenty commented Oct 6, 2024

No description provided.

@lukevalenty lukevalenty force-pushed the lukevalenty/ct_pbt branch 14 times, most recently from 2ad40d0 to eb0642d Compare October 7, 2024 00:08
elbeno
elbeno reviewed Oct 7, 2024
View reviewed changes
elbeno
elbeno reviewed Oct 7, 2024
View reviewed changes
@lukevalenty lukevalenty force-pushed the lukevalenty/ct_pbt branch 9 times, most recently from 1930bac to 2752e04 Compare October 7, 2024 18:14
@lukevalenty lukevalenty enabled auto-merge October 7, 2024 18:44
@lukevalenty lukevalenty requested a review from elbeno October 7, 2024 18:44
elbeno
elbeno reviewed Oct 7, 2024
View reviewed changes
@lukevalenty lukevalenty requested a review from elbeno October 8, 2024 17:22
@lukevalenty lukevalenty force-pushed the lukevalenty/ct_pbt branch 6 times, most recently from bcfb4cc to 5124fa6 Compare October 8, 2024 23:52
@lukevalenty
Copy link
Contributor Author

lukevalenty commented Oct 9, 2024

@elbeno, I'm trying to disable -Wmissing-braces but I'm not able to get it after the all of the warning/error setup. I think we should just disable the check in cicd: intel/cicd-repo-infrastructure#104

@elbeno
Copy link
Contributor

elbeno commented Oct 9, 2024

I don't understand why it needs to be after? But if it really must be, the way to do it is define an extra_warnings INTERFACE library just like warnings and then link it after warnings. CMake is putting the target_compile_options before the things that come from linking libraries.

@elbeno
Copy link
Contributor

elbeno commented Oct 9, 2024

But also, why specify it at all? stdx supplies it.

elbeno
elbeno reviewed Oct 9, 2024
View reviewed changes
@lukevalenty lukevalenty force-pushed the lukevalenty/ct_pbt branch 2 times, most recently from e295747 to d2ad01d Compare October 9, 2024 16:18
@lukevalenty lukevalenty merged commit 4c2c92e into main Oct 9, 2024
32 checks passed
@lukevalenty lukevalenty deleted the lukevalenty/ct_pbt branch October 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elbeno elbeno elbeno approved these changes

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukevalenty @elbeno