✨ Add atomic_bitset
#157
Merged
✨ Add atomic_bitset
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
atomic-bitset
branch
2 times, most recently
from
9dea92b to
be7ba11
Compare
|
Ohhh....this looks cool! 😎 I'm going to take a close look at it later. |
elbeno
force-pushed
the
atomic-bitset
branch
2 times, most recently
from
31df61e to
14e4ebd
Compare
lukevalenty
reviewed
Oct 11, 2024
lukevalenty
reviewed
Oct 11, 2024
Problem: - It is useful to have atomic semantics on a bitset. Solution: - Add `atomic_bitset`. Notes: - `std::atomic<stdx::bitset<N, std::uintXX_t>>` is unwieldy and could not guarantee the use of atomic instructions. - `stdx::bitset<N, std::atomic<std::uintXX_t>>` would not provide the right atomic semantics. - The API of `atomic_bitset` differs from the API of `bitset` in some important ways, but is intended to provide for the use case of effectively using an atomic integral type as a bitset.
lukevalenty
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
atomic_bitset.Notes:
std::atomic<stdx::bitset<N, std::uintXX_t>>is unwieldy and could not guarantee the use of atomic instructions.stdx::bitset<N, std::atomic<std::uintXX_t>>would not provide the right atomic semantics.atomic_bitsetdiffers from the API ofbitsetin some important ways, but is intended to provide for the use case of effectively using an atomic integral type as a bitset.