[SYCL][clang] Implement merging of add_ir_attributes_* attributes #20419
+684
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the implementation logic for merging __sycl_detail__::add_ir_attributes_* attributes, which will enable the ability to apply multiple of the same attribute to the same declaration/definition, as long as the values associated to the same names in the attributes do not conflict. This is needed for SYCL free function support as the way SYCL properties are applied are through macros expanding to __sycl_detail__::add_ir_attributes_* with a single name-value-pair. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| if (checkSYCLAddIRAttributesMergeability(A, *ExistingAttr, *this)) | ||
| return nullptr; | ||
|
|
||
| D->dropAttr<SYCLAddIRAttributesFunctionAttr>(); |
There was a problem hiding this comment.
I don't fully recall how this code works but are you required to drop here if you're dropping in the add function?
There was a problem hiding this comment.
Good point! Since merge is used in multiple places, it makes the most sense to me to remove the attribute dropping in the add function.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| [[__sycl_detail__::add_ir_attributes_function("Attr1", "Attr2", 1, true)]] | ||
| [[__sycl_detail__::add_ir_attributes_function("Attr1", "Attr2", 1, true)]] | ||
| [[__sycl_detail__::add_ir_attributes_function("Attr2", "Attr1", true, 1)]] | ||
| [[__sycl_detail__::add_ir_attributes_function("Attr1", "Attr2", 1, false)]] |
There was a problem hiding this comment.
I don't think you should include invalid tests in AST checks. Unless you're checking the attribute does not get added in this case.
There was a problem hiding this comment.
Right now the two tests have the same set of cases, but I don't necessarily disagree. Would you like me to remove the existing invalid cases as part of this PR or in a follow-up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the implementation logic for merging sycl_detail::add_ir_attributes_* attributes, which will enable the ability to apply multiple of the same attribute to the same declaration/definition, as long as the values associated to the same names in the attributes do not conflict.
This is needed for SYCL free function support as the way SYCL properties are applied are through macros expanding to
sycl_detail::add_ir_attributes_* with a single name-value-pair.