Skip to content

[SYCL][NFC] Avoid temporary object creation when do tracing #20443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][NFC] Avoid temporary object creation when do tracing #20443

wants to merge 1 commit into from
+5 −3

Conversation

@vinser52
Copy link
Contributor

@vinser52 vinser52 commented Oct 23, 2025 •
edited
Loading

Change tracing functions to avoid temporary std::string_view object creation. The issue was that if a string literal is passed as a Msg parameter, the temporary std::string_view object was created. When the constructor of the std::string_view is called, internally it calculates the length of the C-string. This PR avoids that.

@vinser52 vinser52 force-pushed the fix_tracing_kernel_program_cache branch from 366c83f to 8a31ffa Compare October 29, 2025 13:13
@vinser52 vinser52 marked this pull request as ready for review October 29, 2025 13:21
@vinser52 vinser52 requested a review from a team as a code owner October 29, 2025 13:21
@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinser52 @cperkinsintel