Skip to content

[Benchmarks] Benchmarks scripts cleanup #20460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[Benchmarks] Benchmarks scripts cleanup #20460

wants to merge 2 commits into from

Conversation

@PatKamin
Copy link
Contributor

No description provided.

@PatKamin PatKamin requested a review from a team as a code owner October 24, 2025 11:14
@PatKamin
Copy link
Contributor Author

@lslusarczyk, @lukaszstolarczuk, Is the compute.py refactor commit the way we should go? I think it makes moving through this code easier. If yes, I will follow up with all the other benchmarks' modules.

@PatKamin
[Benchmarks] Refactor compute.py module
ebb4dd7 
Improve readability:
- group methods and attributes into public, protected (underscore prefix)
  and private (double underscore prefix)
- order public methods to align with their order in the base
  Benchmark class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lslusarczyk lslusarczyk lslusarczyk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PatKamin @lslusarczyk