Skip to content

[UR] need to use legacy sink on Windows when SYCL_UR_TRACE is active #20566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: sycl
Choose a base branch
from
Draft

[UR] need to use legacy sink on Windows when SYCL_UR_TRACE is active #20566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2049f50
need to use legacy sink on Windows when SYCL_UR_TRACE is active
cperkinsintel Nov 5, 2025
f1aff65
all sinks participate in tearDowned detection
cperkinsintel Nov 7, 2025
dda6c9b
d'oh - didn't mean to delete virtual
cperkinsintel Nov 8, 2025
77082bb
newline on message unnecessary. Limit assign to StderrSink
cperkinsintel Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions unified-runtime/source/adapters/level_zero/adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ class ur_legacy_sink : public logger::Sink {
const std::string &msg) override {
fprintf(stderr, "%s", msg.c_str());
}

~ur_legacy_sink() {
#if defined(_WIN32)
logger::isTearDowned = true;
#endif
};
};

// Find the corresponding ZesDevice Handle for a given ZeDevice
Expand Down
8 changes: 6 additions & 2 deletions unified-runtime/source/common/logger/ur_sinks.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Sink {
// using thier own sink class that inherit from logger::Sink.
#if defined(_WIN32)
if (isTearDowned) {
std::cerr << message << "\n";
std::cerr << message;
} else {
print(level, message);
}
Expand Down Expand Up @@ -193,7 +193,11 @@ class StderrSink : public Sink {
this->flush_level = flush_lvl;
}

~StderrSink() = default;
~StderrSink() {
#if defined(_WIN32)
logger::isTearDowned = true;
#endif
}
};

class FileSink : public Sink {
Expand Down
Loading