Skip to content

[TESTING][SYCL] Enable new offload driver by default for SYCL #20570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Draft

[TESTING][SYCL] Enable new offload driver by default for SYCL #20570

wants to merge 1 commit into from

Conversation

@YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Nov 6, 2025 •
edited
Loading

This PR is created for testing SYCL E2E test that are failing with new offloading model, and will not be merged.

@YixingZhang007 YixingZhang007 requested a review from a team as a code owner November 6, 2025 03:18
@YixingZhang007 YixingZhang007 marked this pull request as draft November 6, 2025 03:19
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from 982225f to 1b0769c Compare November 12, 2025 02:58
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from 1b0769c to c5466d7 Compare November 18, 2025 15:52
mdtoguchi
mdtoguchi reviewed Nov 18, 2025
View reviewed changes
clang/lib/Driver/Driver.cpp
if (const Arg *A = Args.getLastArg(options::OPT_fsycl_targets_EQ)) {
for (const char *Val : A->getValues()) {
llvm::Triple TT(C.getDriver().getSYCLDeviceTriple(Val));
if ((!TT.isSPIROrSPIRV()) || TT.isSPIRAOT())
Copy link
Contributor

@mdtoguchi mdtoguchi Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look to handle values like intel_gpu_pvc or other non-Triple related values for AMD and NVidia. Unclear why we need to have this specific check though, testing for the new offload model for SYCL should only care about -fsycl usage. -fsycl-targets is just a modifier for what -fsycl does.

@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from c5466d7 to b1f16c7 Compare November 18, 2025 18:50
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from b1f16c7 to 75026bb Compare November 18, 2025 20:12
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from 798ea83 to 75026bb Compare November 19, 2025 18:47
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from 75026bb to ef97dee Compare November 25, 2025 20:26
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from ef97dee to d591863 Compare November 27, 2025 14:59
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from d591863 to 634abd3 Compare November 28, 2025 17:18
@YixingZhang007 YixingZhang007 force-pushed the enable_new_offload_model_default branch from 634abd3 to 5d28af3 Compare November 28, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdtoguchi mdtoguchi mdtoguchi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YixingZhang007 @mdtoguchi