-
Notifications
You must be signed in to change notification settings - Fork 796
[sycl-rel-6_3] Extend clang version output #20637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Same as #20520 Except it modifies sycl-rel-nightly.yml instead of sycl-nightly.yml and adds an input to specify a version of release.
|
@intel/dpcpp-devops-reviewers could you please take a look at sycl-rel-nightly.yml just in case. |
sarnex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also nit: typo in pr title
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| sycl_build_info: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we set type and required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are string and false accordingly by-default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool didnt know that
| @@ -0,0 +1,3 @@ | |||
| // RUN: %clang --version 2>&1 | FileCheck %s | |||
|
|
|||
| // CHECK: Intel SYCL compiler{{.*}}based on: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that on the release branch we can actually hardcode the expected version into the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish:D but it would be "Intel SYCL compiler development build based on:" for pre-/post-commit, "Intel SYCL compiler Nightly YYYY-DD-MM build based on:" for Nightly and something like "Intel SYCL compiler X.Y.Z release build based on:" for releases
|
@intel/llvm-gatekeepers please consider merging |
Almost the same as #20520.
Except it modifies
sycl-rel-nightly.ymlinstead ofsycl-nightly.ymland adds an input to specify a version of release.