[SYCL][E2E] Fix lit for arch selection and l0v2 adapter #20728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
changed the title
Comment on lines
+337
to
+341
| backend, device = parsed_dev_name.split(":", 1) | ||
| device_selector = parsed_dev_name | ||
| if backend == "level_zero" and device.isdigit(): | ||
| extra_env.append(f"ZE_AFFINITY_MASK={device}") | ||
| device_selector = f"{backend}:0" |
Contributor
There was a problem hiding this comment.
This needs a comment.
| "opencl": ("cpu", "gpu", "fpga"), | ||
| "cuda": "gpu", | ||
| "level_zero": "gpu", | ||
| "level_zero": ("gpu", "0", "1"), |
Contributor
There was a problem hiding this comment.
Are you trying to allow llvm-lit --param sycl_devices=level_zero:0? We intentionally decided to disallow that in review of #18197
sarnex
reviewed
Nov 21, 2025
| expanded = "env" | ||
|
|
||
| extra_env = get_extra_env([parsed_dev_name]) | ||
| backend, device = parsed_dev_name.split(":", 1) |
Contributor
There was a problem hiding this comment.
The example of the intended lit string after the change in the PR description is
llvm-lit --param "sycl_devices=level_zero_v2:arch-intel_gpu_mtl_u" sycl/test-e2e
but I was expecting something like
llvm-lit --param "sycl_devices='level_zero_v1:gpu;level_zero_v2:gpu" sycl/test-e2e
Can you clarify on the intended use case? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix llvm-lit to enable the simultaneous use of _v1 and _v2 to select the l0 adapter and the use of arch to select the GPU, eg.:
llvm-lit --param "sycl_devices=level_zero_v2:arch-intel_gpu_mtl_u" sycl/test-e2eNecessary to run tests on integrated GPU on system with another GPU
Includes fixed setting of ZE_AFFINITY_MASK in multi-gpu systems