Skip to content

[SYCL][ABI-break] Remove unused host SPIR‑V built‑ins and their symbol exports #20848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 2 commits into from
Dec 8, 2025
+0 −68
Merged

[SYCL][ABI-break] Remove unused host SPIR‑V built‑ins and their symbol exports #20848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4306d84
[SYCL][ABI-break] Remove unused host SPIR‑V built‑ins and their symbo…
againull Dec 5, 2025
e360066
Apply suggestion from @bader
againull Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sycl/doc/design/CompilerAndRuntimeDesign.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,8 +890,6 @@ The SPIR-V specific C++ enumerators and classes are declared in the file:
The SPIR-V specific C++ function declarations are in the file:
`sycl/include/CL/__spirv/spirv_ops.hpp`.

The SPIR-V specific functions are implemented in for the SYCL host device here:
`sycl/source/spirv_ops.cpp`.

### Address spaces handling

Expand Down
1 change: 0 additions & 1 deletion sycl/source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ set(SYCL_COMMON_SOURCES
)

set(SYCL_NON_PREVIEW_SOURCES "${SYCL_COMMON_SOURCES}"
"spirv_ops.cpp"
)


Expand Down
9 changes: 0 additions & 9 deletions sycl/source/ld-version-script.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,6 @@
/* Some functions are also in __host_std, export them as well */
_ZN10__host_std*;

/* Export SPIR-V built-ins for host device */
/* #ifndef __INTEL_PREVIEW_BREAKING_CHANGES */
/* TODO: drop those in the next ABI-breaking window */
_Z23__spirv_GroupWaitEvents*;
_Z22__spirv_ControlBarrier*;
_Z21__spirv_MemoryBarrier*;
_Z20__spirv_ocl_prefetch*;
/* #endif // __INTEL_PREVIEW_BREAKING_CHANGES */

/* Export offload image hooks */
__sycl_register_lib;
__sycl_unregister_lib;
Expand Down
47 changes: 0 additions & 47 deletions sycl/source/spirv_ops.cpp
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions sycl/test/abi/sycl_symbols_linux.dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
# REQUIRES: linux
# UNSUPPORTED: libcxx

_Z20__spirv_ocl_prefetchPKcm
_Z21__spirv_MemoryBarrierN5__spv5ScopeEj
_Z22__spirv_ControlBarrierN5__spv5ScopeES0_j
_Z23__spirv_GroupWaitEventsN5__spv5ScopeEjPPv
_ZN4sycl3_V110__abs_implENS0_3vecIaLi16EEE
_ZN4sycl3_V110__abs_implENS0_3vecIaLi1EEE
_ZN4sycl3_V110__abs_implENS0_3vecIaLi2EEE
Expand Down
4 changes: 0 additions & 4 deletions sycl/test/abi/sycl_symbols_windows.dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3440,10 +3440,6 @@
?__smoothstep_impl@_V1@sycl@@YA?AVhalf@half_impl@detail@12@V34512@00@Z
?__smoothstep_impl@_V1@sycl@@YAMMMM@Z
?__smoothstep_impl@_V1@sycl@@YANNNN@Z
?__spirv_ControlBarrier@@YAXUScope@__spv@@0I@Z
?__spirv_GroupWaitEvents@@YAXUScope@__spv@@IPEAPEAX@Z
?__spirv_MemoryBarrier@@YAXUScope@__spv@@I@Z
?__spirv_ocl_prefetch@@YAXPEBD_K@Z
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$00@12@V312@@Z
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$01@12@V312@@Z
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$02@12@V312@@Z
Expand Down
Loading