Add unit tests #462
Open
Add unit tests #462
+1,797
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a minimum viable test suite covering the main InterLink components: - pkg/interlink: Configuration loading, type serialization, and TLS validation - pkg/interlink/api: HTTP handler tests with OpenTelemetry tracing support - pkg/interlink/cri: Fake runtime service tests for container lifecycle - pkg/virtualkubelet: Configuration and HTTP client tests with TLS support Key features: - 57 passing tests with table-driven patterns - OpenTelemetry integration using in-memory exporters - TLS/mTLS configuration validation - HTTP client behavior testing with httptest - CRI runtime service mock implementation tests Test coverage: - API handlers: 11.8% - CRI service: 23.4% - Virtual Kubelet: 1.5% All tests are isolated and do not require external dependencies, providing a solid foundation for CI/CD integration and future test expansion. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
- Sort imports alphabetically (goimports) - Check all error return values (errcheck) - Remove unused parameters or rename to _ (revive) Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
✅ Deploy Preview for interlink-dev canceled.
|
- Update helm chart installation to use local helm submodule instead of remote OCI registry - Replace git clone of test suite with local test/vk-test-set submodule - Add plugin build from local plugins/slurm submodule using existing Dockerfile - All changes use optional parameters with default paths to submodules Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a minimum viable test suite covering the main
InterLink components:
Fully integrated with the integration test suite already in place.
Related issue :