Draft default flavor behavior for SLURM submissions #101
+966
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dciangot <dciangot@cern.ch>
- Fix flavor default application to only apply when pod doesn't specify limits - Resolve flavor once and pass to produceSLURMScript to avoid redundant resolution - Fix pointer to loop variable issue by creating explicit copies - Improve GPU flavor matching to prefer exact GPU count match - Add SLURM flag deduplication with proper priority handling - Add FlavorConfig validation method with startup checks - Add comprehensive unit tests for all flavor functions (43 new tests) - Update README with detailed flavor system documentation and examples - Remove unused variables (maxCPULimit, maxMemoryLimit) This fixes critical bugs where flavor defaults would override pod-specified resources, and adds proper validation and testing for the flavor system. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue :