feat: add support for Kubernetes startup probes #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add full support for Kubernetes startup probes with proper initialDelaySeconds handling. Startup probes now: - Respect initialDelaySeconds configuration before first execution - Run in background without blocking container startup - Block readiness and liveness probes until successful - Support both HTTP and Exec probe types - Include proper cleanup and error handling Changes: - Add vendor/ to .gitignore to exclude vendored dependencies - Update ContainerCommand struct to include startupProbes field - Extend translateKubernetesProbes to handle startup probe translation - Implement runStartupProbe and waitForStartupProbes functions - Update probe metadata storage/loading for startup probe counts - Add startup probe example demonstrating 300s initial delay - Fix probe script generation to properly sequence probe execution Startup probes follow Kubernetes semantics where they must succeed before other probes begin execution, preventing premature readiness/liveness checks during application initialization. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
dciangot
force-pushed
the
feature/startup-probe-support
branch
from
f4f81f9 to
5e70cfd
Compare
Fix issue where ContainerRuntime defaults to empty string when not specified in config file, causing plugin startup failure. Now properly defaults to 'singularity' for backward compatibility with configs from versions prior to 0.5.2. This allows users to upgrade without modifying their existing config files. Fixes interlink-hq#91 Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full support for Kubernetes startup probes with proper
initialDelaySecondshandling to the interlink-slurm-plugin.Problem
Previously, the plugin only supported readiness and liveness probes, completely ignoring startup probes defined in pod specifications. This meant that pods with startup probes would not respect the
initialDelaySecondsconfiguration, leading to premature probe execution.Additionally, issue #91 reported that ContainerRuntime was not defaulting properly when missing from config files, causing startup failures when upgrading from older versions.
Solution
Implemented complete startup probe support that:
initialDelaySeconds: Startup probes now wait for the configured delay (e.g., 300s) before first executionFixed ContainerRuntime default handling:
Changes
ContainerCommandstruct to includestartupProbesfieldtranslateKubernetesProbes()to handle startup probe translationrunStartupProbe()andwaitForStartupProbes()functionsTesting
go build ./...)go vet ./...)Kubernetes Semantics
This implementation follows Kubernetes startup probe semantics where startup probes must succeed before readiness and liveness probes begin execution, preventing premature health checks during application initialization.
Fixes #91