test: add unit tests for core utility functions #96
+356
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gopkg.in/yaml repository has been archived as of April 2025. This commit migrates to goccy/go-yaml, which is actively maintained and provides better YAML 1.2 spec compliance. Changes: - Replace gopkg.in/yaml.v2 with github.com/goccy/go-yaml v1.18.0 - Update import in pkg/slurm/func.go - Clean up dependencies with go mod tidy Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Add comprehensive unit tests covering: - stringToHex: hex encoding with trailing zero removal - parsingTimeFromString: timestamp parsing validation - prepareImage: image path and prefix handling - GetSessionContext: HTTP header extraction - GetSessionContextMessage: session message formatting - checkIfJidExists: JID lookup verification - removeJID: JID removal functionality All tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Add a new Dagger function to run unit tests via 'make test' in the CI pipeline. This enables automated unit test execution in a containerized environment using the official Go 1.24 image. Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
Signed-off-by: Diego Ciangottini <diego.ciangottini@pg.infn.it>
dciangot
force-pushed
the
feat/add-unit-tests
branch
from
fccc45b to
e566fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive unit tests for core utility functions in the SLURM plugin:
stringToHex: Tests hex encoding with trailing zero removal for various input stringsparsingTimeFromString: Validates timestamp parsing with different formats and error handlingprepareImage: Tests image path handling with prefixes, annotations, and absolute pathsGetSessionContext: Verifies HTTP header extraction for session trackingGetSessionContextMessage: Tests session message formattingcheckIfJidExists: Validates JID lookup functionalityremoveJID: Tests JID removal from the main structureTest Coverage
All tests pass successfully with comprehensive coverage of:
Test Plan
go test ./pkg/slurm/... -v- all tests pass