-
Notifications
You must be signed in to change notification settings - Fork 458
chores(i18n): prepare Turkish translation #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Turkish localization file has been introduced for the frontend application. This file contains comprehensive key-value pairs for user interface strings, covering various application modules and features, and is structured to support full Turkish language translation. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic Password | c18117c | frontend/messages/tr.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
frontend/messages/tr.json (1)
1-1703
: ASCII-only transliterations reduce readabilityAll Turkish strings are written without diacritics (ş, ğ, ı, ç, ö, ü).
While technically safe, this feels unnatural for native speakers and may be considered a defective localisation.Consider using proper Turkish characters and ensuring the file is saved in UTF-8 (JSON is UTF-8 by default).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/messages/tr.json
(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
frontend/messages/tr.json
[error] 23-23: expected ,
but instead found "addThreat"
Remove "addThreat"
(parse)
🔇 Additional comments (1)
frontend/messages/tr.json (1)
1650-1666
: Plural-rules block does not match Turkish grammarTurkish does not have a singular/plural distinction driven by a numeric selector (
one
vsother
).
Providing both branches (countPlural=one
,countPlural=other
) is harmless but unnecessary noise and may confuse translators.Recommend collapsing to a single
other
branch or switching to ICU cardinal-zero style ({count} Saat
) with no plural rule.
I have read the CLA Document and I hereby sign the CLA |
Turkish Language Translation Added
Summary by CodeRabbit