fix: autocomplete options consistency

[nas-tabchiche]

Summary by CodeRabbit

• New Features
  • Enhanced form components to accept and forward additional properties, enabling greater flexibility in form customization.
  • Added support for dynamic URL parameters in select fields based on an optional folder context, improving filtering capabilities for asset and threat selection.
  • Introduced a new folder context property to forms and modals, allowing more precise data scoping and filtering.

[coderabbitai]

Walkthrough

This change enables dynamic prop forwarding in the ModelForm component by adding {...rest} to all its child form components. It also updates the EbiosRmForm and RiskScenarioForm components to accept arbitrary props and utilize a scopeFolder prop for dynamic URL parameterization in select fields. Additional wiring passes the scopeFolder prop from relevant parent pages.

Changes

Cohort / File(s)	Change Summary
ModelForm prop forwarding frontend/src/lib/components/Forms/ModelForm.svelte	Added {...rest} spread attributes to all form component usages, enabling forwarding of arbitrary props to child components without altering existing logic or error handling.
EbiosRmForm dynamic props and URL parameters frontend/src/lib/components/Forms/ModelForm/EbiosRmForm.svelte	Extended Props interface with [key: string]: any, destructured ...rest to capture extra props, and updated AutocompleteSelect components to use optionsDetailedUrlParameters with a conditional scope_folder_id from rest.scopeFolder.id.
RiskScenarioForm dynamic props and URL parameters frontend/src/lib/components/Forms/ModelForm/RiskScenarioForm.svelte	Extended Props interface with [key: string]: any, destructured ...rest, introduced a reactive scopeFolder store, and updated AutocompleteSelect components to use optionsDetailedUrlParameters with a conditional scope_folder_id from scopeFolder.id.
Prop wiring: EBIOS-RM edit page frontend/src/routes/(app)/(internal)/ebios-rm/[id=uuid]/workshop-1/ebios-rm-study/edit/+page.svelte	Passed scopeFolder={data.data.folder} prop to ModelForm component.
Prop wiring: Risk Assessments page frontend/src/routes/(app)/(internal)/risk-assessments/[id=uuid]/+page.svelte	Passed scopeFolder={data.risk_assessment.folder} prop to CreateModal via modalCreateForm.

Sequence Diagram(s)

sequenceDiagram
    participant ParentPage as Parent Page
    participant ModelForm as ModelForm
    participant ChildForm as Specific Form Component (e.g., EbiosRmForm)
    participant AutocompleteSelect as AutocompleteSelect

    ParentPage->>ModelForm: Render with props (including scopeFolder)
    ModelForm->>ChildForm: Render with {...rest} (forwards scopeFolder)
    ChildForm->>AutocompleteSelect: Render with optionsDetailedUrlParameters (uses scopeFolder.id)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

• feat: detailled operating modes and associated graph for EBIOS RM #2276: Adds new model and form components (elementary actions, operating modes, kill chains) that are now included in the prop forwarding logic of this PR.
• feat: select asset from ebios study page #1852: Modifies EbiosRmForm.svelte to add context-based rendering and prop forwarding, related through shared component changes.

Suggested reviewers

• ab-smith

Poem

In fields of forms, a rabbit hops,
Passing props without a single stop.
From folder scope to threat and risk,
Dynamic flows, all neat and brisk.
With every hop, the code grows bright—
Forward we go, with props in flight! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbaefb9 and 8585c6d.

📒 Files selected for processing (1)

• frontend/src/routes/(app)/(internal)/risk-assessments/[id=uuid]/+page.svelte (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/src/routes/(app)/(internal)/risk-assessments/[id=uuid]/+page.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: build_enterprise_frontend
• GitHub Check: migrations-check (3.12)
• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: build (22)

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/temporarily-remove-scope_folder_id

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.