refactor: revert code in custom_analyzer_converter and move logic to the client

Author: Artur-Wisniewski

packages/custom_lint_builder/lib/src/client.dart

@@ -991,12 +991,21 @@ class _ClientAnalyzerPlugin extends analyzer_plugin.ServerPlugin {
         CustomLintEvent.analyzerPluginNotification(
           analyzer_plugin.AnalysisErrorsParams(
             path,
-            CustomAnalyzerConverter().convertAnalysisErrors(
+            CustomAnalyzerConverter()
+                .convertAnalysisErrors(
               allAnalysisErrors,
               lineInfo: resolver.lineInfo,
               options: analysisContext.getAnalysisOptionsForFile(file),
-              configSeverities: configs.configs.errors,
-            ),
+            )
+                .map((error) {
+              var severity = error.severity;
+              if (configs.configs.errors[error.code]
+                  case final ErrorSeverity errorSeverity) {
+                severity = CustomAnalyzerConverter()
+                    .convertErrorSeverity(errorSeverity);
+              }
+              return error.copyWith(severity: severity);
+            }).toList(),
           ).toNotification(),
         ),
       );
@@ -1241,3 +1250,29 @@ extension on ChangeReporterBuilder {
     );
   }
 }
+
+extension on analyzer_plugin.AnalysisError {
+  analyzer_plugin.AnalysisError copyWith({
+    analyzer_plugin.AnalysisErrorSeverity? severity,
+    String? correction,
+    analyzer_plugin.Location? location,
+    String? message,
+    analyzer_plugin.AnalysisErrorType? type,
+    String? code,
+    String? url,
+    List<analyzer_plugin.DiagnosticMessage>? contextMessages,
+    bool? hasFix,
+  }) {
+    return analyzer_plugin.AnalysisError(
+      severity ?? this.severity,
+      type ?? this.type,
+      location ?? this.location,
+      message ?? this.message,
+      code ?? this.code,
+      correction: correction ?? this.correction,
+      url: url ?? this.url,
+      contextMessages: contextMessages ?? this.contextMessages,
+      hasFix: hasFix ?? this.hasFix,
+    );
+  }
+}

packages/custom_lint_builder/lib/src/custom_analyzer_converter.dart

@@ -72,28 +72,23 @@ class CustomAnalyzerConverter {
   /// start column. If an analysis [options] is provided then the severities of
   /// the errors will be altered based on those options.
   List<plugin.AnalysisError> convertAnalysisErrors(
-    List<analyzer.AnalysisError> errors, {
-    analyzer.LineInfo? lineInfo,
-    analyzer.AnalysisOptions? options,
-    Map<String, analyzer.ErrorSeverity>? configSeverities,
-  }) {
-    final serverErrors = <plugin.AnalysisError>[];
-    for (final error in errors) {
-      final processor = analyzer.ErrorProcessor.getProcessor(options, error);
-      final configSeverity = configSeverities?[error.errorCode.name];
-      // Config severities override processor severities
-      final severity = configSeverity ?? processor?.severity;
-
-      // Errors with ignore severity are filtered out.
-      if (severity == analyzer.ErrorSeverity.NONE) {
-        continue;
+      List<analyzer.AnalysisError> errors,
+      {analyzer.LineInfo? lineInfo,
+      analyzer.AnalysisOptions? options}) {
+    var serverErrors = <plugin.AnalysisError>[];
+    for (var error in errors) {
+      var processor = analyzer.ErrorProcessor.getProcessor(options, error);
+      if (processor != null) {
+        var severity = processor.severity;
+        // Errors with null severity are filtered out.
+        if (severity != null) {
+          // Specified severities override.
+          serverErrors.add(convertAnalysisError(error,
+              lineInfo: lineInfo, severity: severity));
+        }
+      } else {
+        serverErrors.add(convertAnalysisError(error, lineInfo: lineInfo));
       }
-
-      serverErrors.add(convertAnalysisError(
-        error,
-        lineInfo: lineInfo,
-        severity: severity,
-      ));
     }
     return serverErrors;
   }