Skip to content

Conversation

@JiriHoffmann
Copy link

Description

Hello! I'm sorry for introducing such a large PR, but I hope it's gonna be worth it.

This PR adds the withCoverter functionality to both the namespace and modular APIs and updates types accordingly.

Both type and e2e tests are a 1:1 copy of the Firebase JS SDK to ensure feature parity.

Related issues

Closes #8611 and these 2 PRs #8698 #8672

Release Summary

Implements withConverter from Firebase JS SDK

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

🔥

@vercel
Copy link

vercel bot commented Nov 7, 2025

@JiriHoffmann is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2025

CLA assistant check
All committers have signed the CLA.

@mikehardy
Copy link
Collaborator

Hello! I'm sorry for introducing such a large PR, but I hope it's gonna be worth it.

That is not something I'm used to people apologizing for, this certainly looks worth it. Thanks! Going in the review queue - additionally - if my patch-package generation workflow is working correctly you should be able to start depending on the work relatively easily already via usage of the patch, which should apply cleanly to the current released version of firestore package on npmjs.com

@mikehardy mikehardy added plugin: firestore Firebase Cloud Firestore Workflow: Needs Review Pending feedback or review from a maintainer. type: enhancement Implements a new Feature labels Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: firestore Firebase Cloud Firestore type: enhancement Implements a new Feature Workflow: Needs Review Pending feedback or review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] 🔥Firestore Typescript types are not working anymore with 22.3.0

3 participants