feat(firestore): implement withCoverter #8744
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello! I'm sorry for introducing such a large PR, but I hope it's gonna be worth it.
This PR adds the withCoverter functionality to both the namespace and modular APIs and updates types accordingly.
Both type and e2e tests are a 1:1 copy of the Firebase JS SDK to ensure feature parity.
Related issues
Closes #8611 and these 2 PRs #8698 #8672
Release Summary
Implements
withConverterfrom Firebase JS SDKChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__🔥