Skip to content

refactor: improved exported types and updated type-tests.ts, intellisense now works #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russellwheatley wants to merge 132 commits into from
Closed

refactor: improved exported types and updated type-tests.ts, intellisense now works #8805

russellwheatley wants to merge 132 commits into from
+8,702 −6,802

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 15, 2025 •
edited
Loading

Description

Fix exported types and type tests for all packages. Intellisense now works for type-test.ts files.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Dec 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-native-firebase Error Error Dec 17, 2025 2:15pm

@russellwheatley russellwheatley changed the title refactor(analytics): move to TypeScript refactor: improved exported types and updated type-tests.ts, now intellisense works Dec 16, 2025
@russellwheatley russellwheatley changed the title refactor: improved exported types and updated type-tests.ts, now intellisense works refactor: improved exported types and updated type-tests.ts, intellisense now works Dec 16, 2025
@russellwheatley russellwheatley marked this pull request as ready for review December 16, 2025 12:43
@russellwheatley russellwheatley mentioned this pull request Dec 16, 2025
Merged
9 tasks
Base automatically changed from refactor-app-typescript to main December 17, 2025 13:37
@russellwheatley
refactor(analytics): move to TypeScript
c4ebf23
@russellwheatley
chore: make index.ts modular and reexport namespaced from there
e342029
@russellwheatley
chore: remove modular folder
d88a41a
@russellwheatley
chore: RN bob builder setup + package.json updates
9f5c8a0
@russellwheatley
tsconfig.json update to find app package
90520fc
@russellwheatley
chore(app): validate.d.ts
104b66d
@russellwheatley
refactor: convert codebase to TypeScript
e28011e
@russellwheatley
chore: resolve index.d.ts issue
19d9ff3
@russellwheatley
chore(analytics): fix types for index.ts
f76e392
@russellwheatley
fix(analytics): RNFBAnalyticsModule make it modular export
e6acc0c
@russellwheatley
fix: analytics with structs
cb1e987
@russellwheatley
chore: remove import
823531d
@russellwheatley
chore: rename to web types
3dcc0d9
@russellwheatley
fix: analytics types
338a149
@russellwheatley
chore: moved types to analytics types
8cbec39
@russellwheatley
chore: fix export types
89b17d6
@russellwheatley
chore: use correct type return + extend getApp()
1c1ef8a
@russellwheatley
fix: export just the type
79c3724
@russellwheatley
use TS from root package
654f1a3
@russellwheatley
yarn.lock
e6ed251
@russellwheatley
chore: rm unneeded type
a6f18c3
@russellwheatley
test: update unit test import
bc697d0
@russellwheatley
refactor: remove types.d.ts file from functions
b9c899f
@russellwheatley
refactor(functions): in light of app package refactor
4ca7eef
@russellwheatley
fix(functions): types for type-test
4b4c329
@russellwheatley
refactor: functions types to remove duplication
338428f
@russellwheatley
fix: type tests were not working, fixed for functions
16ad77c
@russellwheatley
test: include app type test
18a1066
@russellwheatley
test: update root tsconfig.json for jest tests
e387a6c
@russellwheatley
fix: remove globals
d7c0d99
@russellwheatley
fix(other): ensure use getReactNativeModule to get app native module
e7fb747
@russellwheatley
fix: errors for web
14a5e8d
@russellwheatley
fix(app-check): fix test types
bae03c2
@russellwheatley
fix(app-check): add app property
17b6c87
@russellwheatley
fix(auth): update types and test types
aa2e02f
@russellwheatley
fix(crashlytics): update types and test-type file
dd26b13
@russellwheatley
fix(database): fix types and type tests
88c30c5
@russellwheatley
fix(firestore): fix types and type test file
4810b01
@russellwheatley
fix(in-app-messaging): fix types and type test file
39fda8c
@russellwheatley
fix(installations): fix types and type tests
49fd9e0
@russellwheatley
fix(messaging): fix types and test-type file
9a405d3
@russellwheatley
fix(ml): fix types and type test file
550a1ba
@russellwheatley
fix(perf): fix types and type tests
da859a0
@russellwheatley
fix(remote-config): fix types and type test
ee41b41
@russellwheatley
fix: remote config type test
f9895e5
@russellwheatley
fix(storage): types and type test
7252481
@russellwheatley
fix(analytics): fix types and type-test
4f42b19
@russellwheatley
fix: remove eslint warning about empty object
d218a16
@russellwheatley russellwheatley force-pushed the update-types-for-all-packages branch from 2ab72c0 to d218a16 Compare December 17, 2025 14:14
@russellwheatley russellwheatley mentioned this pull request Dec 17, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley