Closing connections on EngineIO._close() #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A socketIO connection can hold two connections open: its transport and its requests.Session instance. These should be closed in __del__ and __exit__.
|
I just experienced the same problem. It is easy to run out of TCP sockets with heavy usage because they are not actually being closed. I can confirm this pull request fixes the problem so it would be well worth merging it @invisibleroads 😉 |
|
I can also verify that this PR fixes #176. @invisibleroads can we expect this fix soon. So, far after many tests I have not encountered any issues caused by this fix and connections closes alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A socketIO connection can hold two connections open: its transport and its requests.Session instance. These should be closed in
__del__()and__exit__().I found that on a Linux system, failure to close the underlying websocket.WebSocket and requests.Session instances causes a file descriptor leak.