fix(select): use aria description for selected option within action sheet #30769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
ShaneK
approved these changes
Nov 7, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Extremely minor grammatical nits, feel free to ignore if you don't wanna run CI just for them 🤷♂️
| const selectedOption = page.locator('.action-sheet-selected'); | ||
| await expect(selectedOption).toHaveAttribute('aria-description', 'selected'); | ||
|
|
||
| // Check that the attribut is not added to non-selected option |
Member
There was a problem hiding this comment.
Suggested change
| // Check that the attribut is not added to non-selected option | |
| // Check that the attribute is not added to non-selected option |
| */ | ||
| configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { | ||
| test.describe(title('select: aria attributes'), () => { | ||
| test('should have a aria-description on the selected option when action sheet interface is open', async ({ |
Member
There was a problem hiding this comment.
Suggested change
| test('should have a aria-description on the selected option when action sheet interface is open', async ({ | |
| test('should have an aria-description on the selected option when action sheet interface is open', async ({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The screen reader does not announce when an option is selected within the action sheet interface. This is because the action sheet uses standard buttons, which do not support a detectable selected state via native properties or ARIA attributes like
aria-checkedoraria-selected, creating an inconsistent user experience across different interface types.What is the new behavior?
aria-description="selected"to the selected option. This will announce the option as "Oranges, button, selected".Downside: The text, "selected", is hard coded in. This causes an internationalization barrier since the text cannot be changed to another language.
Does this introduce a breaking change?
Other information
Basic