refactor(datetime): remove usage of ion-buttons and Phosphor icons #30770
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
FW-6912-datetime
branch
from
df13f40 to
340c060
Compare
There was a problem hiding this comment.
I can't reproduce this shift locally which leads me to believe it's just a rendering difference.
There was a problem hiding this comment.
All ionic theme diffs are due to the arrow icons changing.
There was a problem hiding this comment.
I can't see any difference locally which leads me to believe it's just a rendering difference.
There was a problem hiding this comment.
I can't see any difference locally which leads me to believe it's just a rendering difference.
There was a problem hiding this comment.
I can't reproduce this shift locally which leads me to believe it's just a rendering difference.
There was a problem hiding this comment.
I can't reproduce this shift locally which leads me to believe it's just a rendering difference.
Issue number: N/A
What is the current behavior?
The Datetime component breaks CSP rules due to the following:
ion-buttonswhich usesscopedencapsulation.ionictheme, it imports Phosphor icons as data URIs, which are blocked byconnect-src 'self' blob:.What is the new behavior?
ion-buttons, removing the dependency on a scoped componention-buttonsDoes this introduce a breaking change?