Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .codespellrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[codespell]
skip = .git,*.pdf,*.svg,.codespellrc,*.cs,*.cyberduckprofile,*.ini,*.xib,*.rtf,*.lproj,*.types,TIMEZONES,*.sdef,*.csproj,*.resx,*.plist,swagger
check-hidden = true
ignore-regex = \b(absolute[XY]|CLASSs|characterClasses|connection\.unsecure|perm=fle)\b|.*codespell-ignore.*|wasn't
ignore-words-list = doubleclick,ser,fro,ist,fle
22 changes: 22 additions & 0 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Codespell

on:
push:
branches: [master]
pull_request:
branches: [master]

permissions:
contents: read

jobs:
codespell:
name: Check for spelling errors
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3
- name: Codespell
uses: codespell-project/actions-codespell@v2
10 changes: 5 additions & 5 deletions Changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ https://cyberduck.io/
- [Bugfix] Crash when opening application (Windows) (#15535)

8.7.2
- [Bugfix] Missing digest header when commiting large file upload (Box) (#14564)
- [Bugfix] Missing digest header when committing large file upload (Box) (#14564)
- [Bugfix] Modification date not set in upload (Dropbox) (#15381)
- [Bugfix] Setting modification date truncates file (SMB) (#15495)

Expand Down Expand Up @@ -362,7 +362,7 @@ https://cyberduck.io/

7.8.1
- [Feature] Provide armhf/aarch64 RPM and DEB packages (CLI, Rasperry Pi, Linux) (#10447)
- [Bugfix] Missing folers in directory listing (OneDrive, SharePoint)
- [Bugfix] Missing folders in directory listing (OneDrive, SharePoint)
- [Bugfix] Interoperability with Tencent Cloud Object Storage (S3)
- [Bugfix] No file size displayed for files (Google Drive)

Expand Down Expand Up @@ -702,7 +702,7 @@ https://cyberduck.io/
- [Bugfix] Do not save vault passphrase by default (Cryptomator)
- [Bugfix] Fix failures when attempting to read attributes of incomplete multipart upload (S3)
- [Bugfix] Reloading directory after enabling "Auto detect" in preferences does not ask to unlock vault (Cryptomator) (#10214)
- [Bugfix] Transfer labled incomplete when segment required multiple attempts to finish (S3, OpenStack Swift, Backblaze B2) (#9552)
- [Bugfix] Transfer labeled incomplete when segment required multiple attempts to finish (S3, OpenStack Swift, Backblaze B2) (#9552)

6.3.5
- [Bugfix] Crash on launch in update checker (Windows)
Expand Down Expand Up @@ -1535,7 +1535,7 @@ https://cyberduck.io/
- [Feature] Copy directory listing to clipboard (#2372)
- [Feature] Support for thirdparty terminal applications (#2987)
- [Feature] Change SSH options for open in Terminal.app (#4232)
- [Feature] Unsecure connection warning when password is transmitted in plaintext
- [Feature] Insecure connection warning when password is transmitted in plaintext
- [Feature] Alert to change connection to TLS if server supports AUTH TLS (FTP)
- [Feature] Edit metadata for multiple files (S3, Google Cloud Storage)
- [Feature] Menu items to copy HTTP, CDN, signed & authenticated URLs to clipboard (#4207)
Expand Down Expand Up @@ -1917,7 +1917,7 @@ https://cyberduck.io/
- [Bugfix] Cannot login with colon in username (#309)
- [Bugfix] Cannot delete directory from server (#256)
- [Bugfix] Permission errors when downloading files from read-only directories (#264)
- [Bugfix] Change download keyboad shortcut (#277)
- [Bugfix] Change download keyboard shortcut (#277)
- [Bugfix] Certain operations trigger change of character encoding to default
- [Bugfix] Character encoding issues (#238, #333, #361, #390)
- [Bugfix] Improved compatibility with certain FTP servers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public String selectedColumnIdentifier() {
}

/**
* @return By default no column is editable. To be overriden in subclasses
* @return By default no column is editable. To be overridden in subclasses
*/
public boolean isColumnRowEditable(final NSTableColumn column, final NSInteger row) {
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public void loadBundle(final String bundleName) {
protected boolean awaked;

/**
* Called by the runtime after the NIB file has been loaded sucessfully
* Called by the runtime after the NIB file has been loaded successfully
*/
public void awakeFromNib() {
log.debug("awakeFromNib");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ public static NSApplication sharedApplication() {
* <i>native declaration : :149</i><br>
* Conversion Error : /**<br> * * Present a sheet on the given window. When the modal session is ended,<br> * *
* the didEndSelector will be invoked in the modalDelegate. The didEndSelector<br> * * should have the following
* signature, and will be invoked when the modal session ends.<br> * * This method should dimiss the sheet using
* signature, and will be invoked when the modal session ends.<br> * * This method should dismiss the sheet using
* orderOut:<br> * * - (void)sheetDidEnd:(NSWindow *)sheet returnCode:(NSInteger)returnCode contextInfo:(void
* *)contextInfo;<br> * *<br> * Original signature : <code>void beginSheet(NSWindow*, NSWindow*, id, null,
* void*)</code><br> * /<br> - (void)beginSheet:(NSWindow*)sheet modalForWindow:(NSWindow*)docWindow
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public void setDropItem(NSObject item, NSInteger index) {

/**
* This method returns YES to indicate that auto expanded items should return to their original collapsed state.
* Override this method to provide custom behavior. 'deposited' tells wether or not the drop terminated due to a
* Override this method to provide custom behavior. 'deposited' tells whether or not the drop terminated due to a
* successful drop (as indicated by the return value from acceptDrop:). Note that exiting the view will be treated
* the same as a failed drop.<br> Original signature : <code>BOOL shouldCollapseAutoExpandedItemsForDeposited(BOOL)</code><br>
* <i>native declaration : :183</i>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public void setMaxWidth(double width) {
public abstract com.sun.jna.Pointer sortDescriptorPrototype();

/**
* The resizing mask controls the resizability of a table column. Compatability Note: This method replaces setResizable.<br>
* The resizing mask controls the resizability of a table column. Compatibility Note: This method replaces setResizable.<br>
* Original signature : <code>void setResizingMask(NSUInteger)</code><br>
* <i>native declaration : :78</i>
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public interface Delegate {
public abstract boolean allowsColumnReordering();

/**
* Controls whether the user can attemp to resize columns by dragging between headers. If flag is YES the user can
* Controls whether the user can attempt to resize columns by dragging between headers. If flag is YES the user can
* resize columns; if flag is NO the user can't. The default is YES. Columns can only be resized if a column allows
* user resizing. See NSTableColumn setResizingMask: for more details. You can always change columns
* programmatically regardless of this setting.<br> Original signature : <code>void
Expand Down Expand Up @@ -466,7 +466,7 @@ public interface Delegate {
* <i>native declaration : :212</i><br>
* Conversion Error : /**<br>
* * This method computes and returns an image to use for dragging. Override this to return a custom image. 'dragRows' represents the rows participating in the drag. 'tableColumns' represent the columns that should be in the output image. Note that drawing may be clipped to the visible rows, and columns. 'dragEvent' is a reference to the mouse down event that began the drag. 'dragImageOffset' is an in/out parameter. This method will be called with dragImageOffset set to NSZeroPoint, but it can be modified to re-position the returned image. A dragImageOffset of NSZeroPoint will cause the image to be centered under the mouse.<br>
* * Compatability Note: This method replaces dragImageForRows:event:dragImageOffset:. If present, this is used instead of the deprecated method.<br>
* * Compatibility Note: This method replaces dragImageForRows:event:dragImageOffset:. If present, this is used instead of the deprecated method.<br>
* * Original signature : <code>NSImage* dragImageForRowsWithIndexes(NSIndexSet*, NSArray*, NSEvent*, null)</code><br>
* * /<br>
* - (NSImage*)dragImageForRowsWithIndexes:(NSIndexSet*)dragRows tableColumns:(NSArray*)tableColumns event:(NSEvent*)dragEvent offset:(null)dragImageOffset; (Argument dragImageOffset cannot be converted)
Expand Down Expand Up @@ -541,7 +541,7 @@ public void setDropRow(NSInteger row, NSUInteger op) {

/**
* Sets the column selection using the indexes. Selection is set/extended based on the extend flag. <br>
* Compatability Note: This method replaces selectColumn:byExtendingSelection:<br> If a subclasser implements only
* Compatibility Note: This method replaces selectColumn:byExtendingSelection:<br> If a subclasser implements only
* the deprecated single-index method (selectColumn:byExtendingSelection:), the single-index method will be invoked
* for each index. If a subclasser implements the multi-index method (selectColumnIndexes:byExtendingSelection:),
* the deprecated single-index version method will not be used. This allows subclassers already overriding the
Expand All @@ -555,7 +555,7 @@ public void setDropRow(NSInteger row, NSUInteger op) {
/**
* Sets the row selection using 'indexes'. Selection is set/extended based on the extend flag. On 10.5 and greater,
* selectRowIndexes:byExtendingSelection: will allow you to progrmatically select more than one index, regardless of
* the allowsMultipleSelection and allowsEmptySelection options set on the table.<br> Compatability Note: This
* the allowsMultipleSelection and allowsEmptySelection options set on the table.<br> Compatibility Note: This
* method replaces selectRow:byExtendingSelection:<br> If a subclasser implements only the deprecated single-index
* method (selectRow:byExtendingSelection:), the single-index method will be invoked for each index. If a
* subclasser implements the multi-index method (selectRowIndexes:byExtendingSelection:), the deprecated
Expand Down Expand Up @@ -782,7 +782,7 @@ public void editRow(NSInteger column, NSInteger row, boolean select) {
* Conversion Error : NSRect
*/
/**
* Deprecated in Mac OS 10.3. Calls setGridStyleMask:, setting grid style to either None, or vertical and horizonal
* Deprecated in Mac OS 10.3. Calls setGridStyleMask:, setting grid style to either None, or vertical and horizontal
* solid grid lines as appropriate.<br> Original signature : <code>void setDrawsGrid(BOOL)</code><br>
* <i>from NSDeprecated native declaration : :506</i>
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ interface NSSearchPathDomainMask {
int NSUserDomainMask = 1;
/// local to the current machine --- place to install items available to everyone on this machine (/Library)
int NSLocalDomainMask = 2;
/// publically available location in the local area network --- place to install items available on the network (/Network)
/// publicly available location in the local area network --- place to install items available on the network (/Network)
int NSNetworkDomainMask = 4;
/// provided by Apple, unmodifiable (/System)
int NSSystemDomainMask = 8;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public interface _Class extends ObjCClass {
public abstract NSArray contentsOfDirectoryAtPath_error(String path, ObjCObjectByReference error);

/**
* subpathsOfDirectoryAtPath:error: returns an NSArray of Strings represeting the filenames of the items in the
* subpathsOfDirectoryAtPath:error: returns an NSArray of Strings representing the filenames of the items in the
* specified directory and all its subdirectories recursively. If this method returns 'nil', an NSError will be
* returned by reference in the 'error' parameter. If the directory contains no items, this method will return the
* empty array.<br> This method replaces subpathsAtPath:<br> Original signature :
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ public interface _Class extends ObjCClass {

/**
* Original signature : <code>BOOL getCString(char*, NSUInteger, NSStringEncoding)</code><br>
* NO return if conversion not possible due to encoding errors or too small of a buffer. The buffer should include room for maxBufferCount bytes; this number should accomodate the expected size of the return value plus the NULL termination character, which this method adds. (So note that the maxLength passed to this method is one more than the one you would have passed to the deprecated getCString:maxLength:.)<br>
* NO return if conversion not possible due to encoding errors or too small of a buffer. The buffer should include room for maxBufferCount bytes; this number should accommodate the expected size of the return value plus the NULL termination character, which this method adds. (So note that the maxLength passed to this method is one more than the one you would have passed to the deprecated getCString:maxLength:.)<br>
* <i>from NSStringExtensionMethods native declaration : :192</i>
*/
public abstract boolean getCString_maxLength_encoding(java.nio.ByteBuffer buffer, NSUInteger maxBufferCount, NSUInteger encoding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ public File upload(final Path file, final Local local, final BandwidthThrottle t
.size(f.status.getLength()).offset(f.status.getOffset()).partId(f.part.getId())).collect(Collectors.toList()));
final Optional<File> optional = files.getEntries().stream().findFirst();
if(optional.isPresent()) {
final File commited = optional.get();
final File committed = optional.get();
// Mark parent status as complete
status.withResponse(new BoxAttributesFinderFeature(session, fileid).toAttributes(commited)).setComplete();
return commited;
status.withResponse(new BoxAttributesFinderFeature(session, fileid).toAttributes(committed)).setComplete();
return committed;
}
throw new NotfoundException(file.getAbsolute());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public boolean retryRequest(final HttpResponse response, final int executionCoun
}
// Pairing token no longer valid
if(!semaphore.tryAcquire()) {
log.warn(String.format("Skip pairing because semaphore cannot be aquired for %s", session));
log.warn(String.format("Skip pairing because semaphore cannot be acquired for %s", session));
return false;
}
try {
Expand Down
Loading