Android 16kb openalsoft update #2552
Open
+158
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync fork
Update fork
… in the atlases instead of setting a predefined byte buffer on disposal that made all atlases in the backend use the same buffer and generated rendering issues.
Fork update
…d more images to the screens so it really uses more atlases
Update fork PR
Update fork
Update fork
…_PAGE_SIZES to all android native libraries
|
I think we can use this updated image instead of jmonkeyengine/buildenv-jme3:android |
…ndroid-sdk:35-ndk
|
Thanks @riccardobl for the tip. The linked image properly passed the build android natives step but every other step is failing when trying to download the native artifact. Any help is appreciated |
|
looks like the 'Build natives for android' job is not uploading any artifact maybe the path changed? |
…set NDK path for android natives
|
The issue was that the NDK path was not properly set and cmake was missing in the image. I didn't realized you already fixed it in ngengine workflow. Should now work. Thanks ;) |
riccardobl
requested changes
Oct 10, 2025
| -DRESTRICT="" \ | ||
| -DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=true | ||
|
|
||
| LOCAL_LDLIBS := -lOpenSLES -llog -Wl,-s -lc++_shared |
There was a problem hiding this comment.
Suggested change
| LOCAL_LDLIBS := -lOpenSLES -llog -Wl,-s -lc++_shared | |
| LOCAL_LDLIBS := -lOpenSLES -llog -Wl,-s -lc++_static -lc++abi |
| '-DALSOFT_SHARED=OFF', | ||
| '-DBUILD_SHARED_LIBS=OFF', | ||
| '-DALSOFT_STATIC=ON', | ||
| '-DLIBTYPE=STATIC' |
There was a problem hiding this comment.
Suggested change
| '-DLIBTYPE=STATIC' | |
| '-DLIBTYPE=STATIC', | |
| '-DCMAKE_CXX_FLAGS=-stdlib=libc++' | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the conversation at https://hub.jmonkeyengine.org/t/android-16kb-page-size-support/48536 I've decided to create this PR for everyone using jme3 for android to avoid the 16kb page issues reported by bzbit
This PR includes the openalsoft update by @riccardobl and sets ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES for all android native libraries
This change also requires the docker image "jmonkeyengine/buildenv-jme3:android" to be rebuilt including at least ndk v29