pgio: optimize append/set functions with direct byte shifts #2461
+7
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace zero-fill + overwrite pattern with direct byte appends. Use array pointer cast in SetInt32 to eliminate bounds checks. Benchmarks show 12-19% improvement in message building: BindMessage5Params: 164 ns → 132 ns (19% faster) BindMessage20Params: 922 ns → 780 ns (15% faster) Simulate10kQueries: 1.37ms → 1.21ms (12% faster) Assembly comparison for SetInt32: Before: 134 bytes, 4 bounds checks, 4 panicIndex calls After: 63 bytes, 1 bounds check, 1 panicSliceConvert call No functional changes. All existing tests pass.
Owner
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace zero-fill + overwrite pattern with direct byte appends. Use array pointer cast in SetInt32 to eliminate bounds checks.
Benchmarks show 12-19% improvement in message building:
BindMessage5Params: 164 ns → 132 ns (19% faster)
BindMessage20Params: 922 ns → 780 ns (15% faster)
Simulate10kQueries: 1.37ms → 1.21ms (12% faster)
Assembly comparison for SetInt32:
Before: 134 bytes, 4 bounds checks, 4 panicIndex calls
After: 63 bytes, 1 bounds check, 1 panicSliceConvert call
No functional changes. All existing tests pass.