perf(pgtype): pre-allocate error sentinels for NULL scans #2463
+41
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~320x faster NULL scanning with zero allocations. Benchmark results: - NULL scan: 97 ns → 0.3 ns - Mixed (2 NULL / 5 cols): 199 ns → 5.5 ns - Memory: 48 B/op → 0 B/op per NULL Adds 15 sentinel error variables (~800 bytes total, allocated once at startup) for common NULL-into-non-pointer scan errors. Non-NULL error paths unchanged. Also fixes uintWrapper.ScanInt64 error message (*uint64 → *uint). Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
analytically
force-pushed
the
perf/preallocerror
branch
from
eb4d7f1 to
6af62d0
Compare
Owner
|
Is there a case where this has a real world impact? It's optimizing an error path that should only be triggered by application bugs. |
Contributor
Author
|
Impacts:
It's a low-risk change with occasional high payoff. |
Owner
|
If you are scanning something that can be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~320x faster NULL scanning with zero allocations.
Benchmark results:
Adds 15 sentinel error variables (~800 bytes total, allocated once at startup) for common NULL-into-non-pointer scan errors. Non-NULL error paths unchanged.
Also fixes uintWrapper.ScanInt64 error message (*uint64 → *uint).