🧑💻 🎓 ESAP --- Negative operands for load direct instructions #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or PRs
Resolves #226
What
Why
Turns out the system's underlying design can't handle negative 4 bit operands as they get padded with 0s to become 8 bits, thereby removing their ability to be negative.
Where
Assembler & topic introducing the instructions
How
Testing
👍 (assembler manually and built local to view warning)
Additional Notes
Actually discussed this in detail in lecture today. Fun thing to discuss.
Although hardware could probably be designed to deal with this, the additional complexity is not worth it.