Update react peerDependency in package.json
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing `react-lazily-render` in a project using React 17 or 18 fails with the following error: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: marcnitzsche.de@0.1.0 npm ERR! Found: react@18.0.0 npm ERR! node_modules/react npm ERR! react@"18.0.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.1.1" from react-lazily-render@1.2.0 npm ERR! node_modules/react-lazily-render npm ERR! react-lazily-render@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. ``` A workaround is using `npm install react-lazily-render --force` which works without problems. As the package is working in newer React versions already, I propose updating its peer dependencies. Generally, though, we should re-run the tests against the newer versions of React to see if anything breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing
react-lazily-renderin a project using React 17 or 18 fails with the following error:A workaround is using
npm install react-lazily-render --forcewhich works without problems. As the package is working in newer React versions already, I propose updating its peer dependencies. Generally, though, we should re-run the tests against the newer versions of React to see if anything breaks.