[MAJOR BUG FIX] - Fixed bad free() calls, fixed decrement bug for ht_delete #58
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, calling ht_delete with key that's not in the hash table would result in ht_count being decremented anyway. Also added an early return for when the item is marked as no further checks need to be made.
Before, free() would be called on pointers to HT_DELETED_ITEM, resulting in an error
tshmieldev
changed the title
|
@jamesroutley I believe those fixes are important, people are learning from this repo. Please review my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, in ht_del_hash_table, free() would be called on pointers to HT_DELETED_ITEM, resulting in an error.
Also before, calling ht_delete with key that's not in the hash table would result in ht_count being decremented anyway.
Added an early return for when the item is marked as no further checks need to be made.