Add mlflow services and config #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswilliams1
requested changes
Mar 6, 2021
| @@ -1,4 +1,7 @@ | |||
| # MLflow Production Docker | |||
| POSTGRES_DB= | ||
| # Mlflow settings | ||
| MLFLOW_ARTIFACT_URI=s3://bucket-name/ | ||
| # If using bentoml for deployment |
| POSTGRES_PORT= | ||
| POSTGRES_DB= | ||
| # Mlflow settings | ||
| MLFLOW_ARTIFACT_URI=s3://bucket-name/ |
| build: | ||
| context: . | ||
| dockerfile: ./dockerfiles/traefik/Dockerfile | ||
| image: mlflow_production_traefik |
There was a problem hiding this comment.
image names clash with prod file, will cause overwrite
Comment on lines
+39
to
+47
| postgres: | ||
| image: postgres:11.8 | ||
| restart: always | ||
| env_file: | ||
| - .env | ||
| ports: | ||
| - "5432:5432" | ||
| volumes: | ||
| - local_postgres_data:/var/lib/postgresql/data No newline at end of file |
There was a problem hiding this comment.
this is the only change over the other file, just drop in a new docker-compose-local.yml file and can run docker-compose up with both rather than copy paste
| >&2 echo 'Sleeping till postgres is ready...' | ||
| sleep 1 | ||
| done | ||
| >&2 echo 'PostgreSQL is available' |
There was a problem hiding this comment.
Suggested change
| >&2 echo 'PostgreSQL is available' | |
| echo 'PostgreSQL is available' |
this isnt an error, should go to stdout
| COPY ./start /start | ||
| RUN sed -i 's/\r$//g' /start && chmod +x /start | ||
|
|
||
| ENTRYPOINT [ "/entrypoint" ] No newline at end of file |
There was a problem hiding this comment.
Suggested change
| ENTRYPOINT [ "/entrypoint" ] | |
| ENTRYPOINT [ "/entrypoint" ] | |
| CMD ["/start"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.