feat: move cache measurements to dedicated decorator #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
f639825 to
73ee1bd
Compare
jasuwienas
changed the title
jasuwienas
force-pushed
the
4558-cache-client
branch
from
5ca2b03 to
6df6f50
Compare
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
73ee1bd to
fd3aaf5
Compare
jasuwienas
force-pushed
the
4558-cache-client
branch
from
6df6f50 to
28e225c
Compare
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
4750ac7 to
e61d626
Compare
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
e61d626 to
2d9eb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic responsible for collecting metrics is being moved into a separate service.
The CacheService is being updated to implement the ClientInterface (which effectively makes the CacheService itself redundant). It will be kept only as an alias for the client.
Related issue(s)
Fixes #hiero-ledger#4558
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
Deprecatd methods can be removed in the future.
Checklist