feat: use get instead of getasync (#4558) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
73ee1bd to
fd3aaf5
Compare
jasuwienas
force-pushed
the
4558-cache-client-measurements-by-decorator-use-get-instead-of-getasync
branch
from
e9a5a81 to
264f1d3
Compare
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
4750ac7 to
e61d626
Compare
jasuwienas
force-pushed
the
4558-cache-client-measurements-by-decorator-use-get-instead-of-getasync
branch
from
264f1d3 to
c2fd153
Compare
jasuwienas
force-pushed
the
4558-cache-measurements-by-decorator
branch
from
e61d626 to
2d9eb0a
Compare
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
jasuwienas
force-pushed
the
4558-cache-client-measurements-by-decorator-use-get-instead-of-getasync
branch
2 times, most recently
from
0da38a0 to
393b529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No need to use cacheService.getAsync and cacheService.get methods.
getwill be enough.Related issue(s)
Fixes hiero-ledger#4558
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist