Skip to content

Conversation

basola21
Copy link

@basola21 basola21 commented Apr 4, 2025

#231

adding the integration for content square. took inspiration from hotjar

@basola21 basola21 requested a review from Copilot April 4, 2025 06:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • docs/services/content_square.rst: Language not supported
Comments suppressed due to low confidence (1)

analytical/templatetags/content_square.py:14

  • [nitpick] The generated tracking code omits the spacing expected by the tests. Please align the formatting (e.g. include spaces around operators) with the expected HTML to ensure an exact match.
        c.hj=c.hj||function(){(c.hj.q=c.hj.q||[]).push(arguments)};

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bittner
Copy link
Member

bittner commented Apr 4, 2025

Looks like we first need to fix/update the CI setup. This is long overdue. 😟

@bittner
Copy link
Member

bittner commented Apr 4, 2025

@copilot Fix the pipeline in a separate PR! 🤣

@basola21
Copy link
Author

basola21 commented Apr 4, 2025

seems like this did not do the trick, try chat gpt maybe ?

@basola21 basola21 marked this pull request as draft April 4, 2025 07:06
@bittner bittner changed the title added the content square docs,template tag and tests Add ContentSquare (template tag, tests and docs) Apr 4, 2025
@bittner
Copy link
Member

bittner commented Apr 4, 2025

I opened PR #233 to unblock this PR. As soon as those changes are merged you can rebase your changes and the pipeline should succeed.

@bittner
Copy link
Member

bittner commented Jul 8, 2025

Can you now rebase your PR? The pipeline should now pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants