Skip to content

Conversation

cjsoftuk
Copy link

Description

This branch provides a potential fix for issue #621

Motivation and Context

This solves the issue of the next parameter not being passed across.

How Has This Been Tested?

I have tested this in the application I was having the issue in, and from a user view point it seems to do exactly what I expect.
I have not yet built any specific tests for this functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I welcome feedback on the proposed change, and understand that I probably need to build tests for it before anyone is prepared to merge it.

Copy link
Collaborator

@moggers87 moggers87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests required and remove the session logic from SetupCompleteView please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants