Skip to content

Allow titling of orderable_handle_column #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hegedak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow titling of orderable_handle_column #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/activeadmin-orderable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module TableMethods
HANDLE = '↕'.html_safe

def orderable_handle_column options = {}
column '', :class => "activeadmin-orderable" do |resource|
column options[:title], :class => "activeadmin-orderable" do |resource|
Copy link
Collaborator

@houndci-bot houndci-bot Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

sort_url = if options[:url].is_a? Symbol
send options[:url], resource
elsif options[:url].respond_to? :call
Expand Down