Skip to content

fix: update zap2it URL #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix: update zap2it URL #13

merged 1 commit into from
Apr 2, 2025

Conversation

hackwin
Copy link
Contributor

@hackwin hackwin commented Mar 29, 2025

zap2it is now https://tvlistings.gracenote.com

Description

Login was failing. Zap2it TV listings are now on Gracenote.com.
The user/password is the same. The API is the same. Just the URL has changed.

Testing

The Perl file can be run with the same arguments as before.

@hackwin hackwin requested a review from jef as a code owner March 29, 2025 21:30
Copy link
Contributor

@depwl9992 depwl9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest also editing URLs in the stationToChannel and printHeader subroutines as these don't use $urlRoot.

Additionally, in the XML file I see <programme><url></url></programme> is generated by parseJSON on line 1346. The base output is currently https://tvlistings.gracenote.com//overview.html. This works, but should technically resolve to tvlistings.gracenote.com/overview-affiliates.html. Here's the change I made to accomplish that:

$programs{$cp}{url} = $urlRoot . "overview-affiliates.html?programSeriesId="
                . $program->{seriesId} . "&tmsId=" . $program->{tmsId};

@jef
Copy link
Owner

jef commented Apr 2, 2025

Suggest also editing URLs in the stationToChannel and printHeader subroutines as these don't use $urlRoot.

Additionally, in the XML file I see <programme><url></url></programme> is generated by parseJSON on line 1346. The base output is currently https://tvlistings.gracenote.com//overview.html. This works, but should technically resolve to tvlistings.gracenote.com/overview-affiliates.html. Here's the change I made to accomplish that:

$programs{$cp}{url} = $urlRoot . "overview-affiliates.html?programSeriesId="
                . $program->{seriesId} . "&tmsId=" . $program->{tmsId};

Do you mind making a PR to add this? Seems like a great contribution :)

@jef jef changed the title Update zap2xml.pl fix: update zap2it URL Apr 2, 2025
@jef jef merged commit a41eab9 into jef:main Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants