-
-
Notifications
You must be signed in to change notification settings - Fork 26
ci: add windows exe build #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Windows executable building capabilities to the CI/CD pipeline to address issue #27. The changes introduce Windows executable generation using Perl's PAR::Packer alongside the existing Docker image builds.
- Adds Windows executable build step to the release workflow with automatic upload to GitHub releases
- Updates nightly release workflow to use more recent GitHub Actions and improved output handling
- Introduces Windows executable build job in CI workflow for testing pull requests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
File | Description |
---|---|
.github/workflows/release.yaml |
Adds Windows executable build steps and updates release-please action version |
.github/workflows/nightly-release.yaml |
Refactors workflow structure and updates to newer GitHub Actions syntax |
.github/workflows/ci.yaml |
Adds Windows executable build job for CI testing |
@ferrellsl, perhaps you can help me with this workflow by reviewing and suggesting some changes? Thanks! :) |
I won't be much help in regard to the workflow for nightly builds because of my lack of skills but I do need to update the Windows Guide for NOOBS and remove the line regarding the updated user agent since you've incorporated that change in your latest zap2xml.pl source code. |
Closing this in favor of #35 |
Description
Closes #27.
Will test within branch to make sure it works.