Skip to content

ci: add windows exe build #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

ci: add windows exe build #33

wants to merge 13 commits into from

Conversation

jef
Copy link
Owner

@jef jef commented Jul 15, 2025

Description

Closes #27.

Will test within branch to make sure it works.

@jef jef requested a review from Copilot July 15, 2025 23:47
Copilot

This comment was marked as outdated.

@jef jef requested a review from Copilot July 15, 2025 23:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Windows executable building capabilities to the CI/CD pipeline to address issue #27. The changes introduce Windows executable generation using Perl's PAR::Packer alongside the existing Docker image builds.

  • Adds Windows executable build step to the release workflow with automatic upload to GitHub releases
  • Updates nightly release workflow to use more recent GitHub Actions and improved output handling
  • Introduces Windows executable build job in CI workflow for testing pull requests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/release.yaml Adds Windows executable build steps and updates release-please action version
.github/workflows/nightly-release.yaml Refactors workflow structure and updates to newer GitHub Actions syntax
.github/workflows/ci.yaml Adds Windows executable build job for CI testing

@jef
Copy link
Owner Author

jef commented Jul 16, 2025

@ferrellsl, perhaps you can help me with this workflow by reviewing and suggesting some changes?

Thanks! :)

@ferrellsl
Copy link

@ferrellsl, perhaps you can help me with this workflow by reviewing and suggesting some changes?

Thanks! :)

I won't be much help in regard to the workflow for nightly builds because of my lack of skills but I do need to update the Windows Guide for NOOBS and remove the line regarding the updated user agent since you've incorporated that change in your latest zap2xml.pl source code.

@jef
Copy link
Owner Author

jef commented Jul 18, 2025

Closing this in favor of #35

@jef jef closed this Jul 18, 2025
@jef jef deleted the ci/windows-build branch July 18, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Guide For Compiling the zap2xml.pl into an EXE for NOOBS
2 participants