Skip to content

Conversation

rcrichton
Copy link
Contributor

Adds Loki with a Minio storage backend for storing service logs.

I couldn't get Loki to work in cluster mode as there appears to be a bug when running it in docker swarm. See my draft PR here for that work: #210

To test:

  • Start the monitoring package
  • Navigate to grafana on http://localhost:3000/
  • Under dashboards in the containers folder there is a new dashbaord 'container logs'
  • You may also explore the logs using Grafana's explore feature directly
  • You can also view the Minio dashboard at: http://localhost:9001/

@rcrichton rcrichton marked this pull request as draft January 20, 2023 14:46
@rcrichton rcrichton marked this pull request as ready for review January 20, 2023 14:46
Copy link
Contributor

@michaelloosen michaelloosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, mainly small naming convention changes.

@rcrichton
Copy link
Contributor Author

Thanks for all the feedback everyone. Good points. I'l work on this again when a have some space.

@rcrichton rcrichton marked this pull request as draft February 8, 2023 15:07
@rcrichton rcrichton requested a review from nour-borgi February 8, 2023 15:08
@rcrichton rcrichton marked this pull request as ready for review February 8, 2023 15:08
Copy link
Contributor

@nour-borgi nour-borgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice!

@rcrichton rcrichton marked this pull request as draft February 9, 2023 08:11
@rcrichton rcrichton marked this pull request as ready for review February 9, 2023 08:11
@rcrichton rcrichton marked this pull request as draft February 9, 2023 12:27
@rcrichton rcrichton marked this pull request as ready for review February 9, 2023 12:27
@nour-borgi
Copy link
Contributor

I remembered that you need to add a condition in the CI folder in run-tests.sh, so that if we made a change in monitoring it will not run all the tests

@rcrichton rcrichton marked this pull request as draft February 23, 2023 13:07
@rcrichton rcrichton marked this pull request as ready for review February 23, 2023 13:07
@rcrichton rcrichton marked this pull request as draft February 23, 2023 14:20
@rcrichton rcrichton marked this pull request as ready for review February 23, 2023 14:21
@rcrichton rcrichton marked this pull request as draft February 24, 2023 09:22
@rcrichton rcrichton marked this pull request as ready for review February 24, 2023 09:22
@michaelloosen michaelloosen merged commit cc42a24 into main Feb 24, 2023
@michaelloosen michaelloosen deleted the logging branch February 24, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants