Skip to content

Upgrade to use jcasc test harness #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Upgrade to use jcasc test harness #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>3.50</version>
<version>3.55</version>
<relativePath />
</parent>
<artifactId>github-branch-source</artifactId>
Expand All @@ -27,9 +27,9 @@
<java.level>8</java.level>
<jenkins.version>2.150.3</jenkins.version>
<scm-api.version>2.6.3</scm-api.version>
<hamcrest.version>2.1</hamcrest.version>
<hamcrest.version>2.2</hamcrest.version>
<useBeta>true</useBeta>
<jcasc.version>1.30</jcasc.version>
<jcasc.version>1.35</jcasc.version>
</properties>

<scm>
Expand All @@ -44,6 +44,11 @@
<artifactId>structs</artifactId>
<version>1.19</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jackson2-api</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as to why a new dependency needs to be introduced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-api-plugin depends on this plugin, so it's not really adding a new dep, but the released version is very out-dated (causing enforcer errors).

If someone wants to release github-api-plugin then this dependency change is unneeded

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/github-api-plugin#35 is going to remove this dependency. Hopefully that gets released and you can just depend on the new version. @bitwiseman are you planning a new release soon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, there shouldn't be a conflict anymore and then this dependency could be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@res0nance
I'm planning to release as soon as I reasonably can, in the meanwhile. I'll take this PR as it stands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this as of #269 anyway.

<version>2.10.2</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>scm-api</artifactId>
Expand Down Expand Up @@ -193,10 +198,9 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.jenkins</groupId>
<artifactId>configuration-as-code</artifactId>
<groupId>io.jenkins.configuration-as-code</groupId>
<artifactId>test-harness</artifactId>
<version>${jcasc.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
Expand Down