Skip to content

[JENKINS-62249] Delegate GitHub App token generation from agents and improve caching #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 1, 2020
Merged

[JENKINS-62249] Delegate GitHub App token generation from agents and improve caching #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fd58e5e
GitHubAppCredentials on remote side to use SlaveToMasterCallable
jglick Aug 20, 2020
22ef38d
SpotBugs
jglick Aug 20, 2020
74902c3
No need to contact controller just to get appID
jglick Aug 20, 2020
7f23a79
Secret.fromString will not work on the agent side prior to 2.235.x
jglick Aug 20, 2020
de2860b
Maybe it works to call the Secret ctor on the controller side (the se…
jglick Aug 20, 2020
790ec23
Adding some JenkinsJVM calls to try to clarify the control flow
jglick Aug 20, 2020
e48eb83
Possibly more descriptive name
jglick Aug 20, 2020
8367aeb
Add accurate token expiration and agent-side caching
bitwiseman Aug 24, 2020
1443730
Add more logging
bitwiseman Aug 24, 2020
b76dbdb
Add test for AppInstallationToken
bitwiseman Aug 25, 2020
3ab69eb
Update src/main/java/org/jenkinsci/plugins/github_branch_source/GitHu…
bitwiseman Aug 25, 2020
23773cd
Renamed token test
bitwiseman Aug 28, 2020
81c9163
Add test for GitHubAppCredentials
bitwiseman Aug 30, 2020
dc3b565
Addtional testing revealed poor behavior
bitwiseman Aug 30, 2020
52526b4
Check validity of app token before sending to agents
bitwiseman Aug 31, 2020
54e01d5
Merge remote-tracking branch 'upstream/master' into issue/appid-expir…
bitwiseman Sep 1, 2020
3ac6082
Simplified log checking
bitwiseman Sep 1, 2020
d80588e
Update based on review feedback
bitwiseman Sep 1, 2020
b605c64
Switch to JSONObject for data blob
bitwiseman Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
<artifactId>github</artifactId>
<version>1.31.0</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-support</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Timeout I guess. Wonder if this should be moved to the likes of plugin-util-api…

</dependency>
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-api</artifactId>
Expand Down Expand Up @@ -92,6 +96,24 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-basic-steps</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>git</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
</exclusions>
</dependency>


<!-- JCasC compatibility -->
<dependency>
Expand Down
Loading