fix: fixed panGestureAnimatedValue change on content scroll down #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was described here #471.
I found out that the modal could be closed by swiping the child scroll (ScrollView, FlatList ...) down only if that child list is on the top and was on the top at the moment when the drag gesture was started. So I added the check in handleGestureEvent that checks if the list was already in the top so the calculation for panGestureAnimatedValue starts. This should be valid as long as panGestureAnimatedValue value does what was described in docs "Animated.Value of the modal opening position between 0 and 1."